fix: correct loc.start for classconstant and propertystatement with attributes#1225
Merged
Conversation
czosel
approved these changes
Mar 25, 2026
Collaborator
|
This has been fixed in a previous PR, right? Can you link to it, for future reference? |
jorgsowa
force-pushed
the
fix/attr-group-loc-start-class-members
branch
from
6cd52a1 to
08df352
Compare
Collaborator
Author
|
Not really. I messed up something in this PR and didn't include the fix. I will change to draft and fix later. Too many PRs were opened from my side. |
Collaborator
|
No worries, your work is much appreciated! 👍 |
jorgsowa
force-pushed
the
fix/attr-group-loc-start-class-members
branch
from
b586fef to
3b6070d
Compare
jorgsowa
force-pushed
the
fix/attr-group-loc-start-class-members
branch
from
3b6070d to
10678ec
Compare
Collaborator
Author
|
I didn't push all changes from my branch. Now it's ultimately fixed. Accessibility keywords were not properly assigned, and the locations were wrong for constants. |
Collaborator
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prettier/plugin-php#2436
The issue was with the wrong location of attributes.